New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use fmt.Errorf instead of errors.Wrap #146

Open

flaneur2020 wants to merge 1 commit into databendlabs:main from flaneur2020:chore/tune-errors-wrap

Member

flaneur2020 commented Jan 14, 2025

it seems that errors.Wrap was introduced before fmt.Errorf() in the stdlib was introduced.

the current error message is like:

context canceled: DoRequestFailed

the convention is becoming to put the root cause part into the right side, for example:

do request failed: context canceled


          chroe

fdcd41a

Contributor

forsaken628 commented Jan 17, 2025

github.com/pkg/errors provides stack information that will make debugging easier, otherwise we need to carefully handle the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet