Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-clients-timeout option #8757

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add no-clients-timeout option #8757

wants to merge 2 commits into from

Conversation

tmi
Copy link

@tmi tmi commented Jul 10, 2024

Closes #7959 .

I aimed for a minimalistic implementation, and named it consistently with the existing no_workers_timeout.

  • The original issue does not address whether to respect running/queued jobs or not, I chose to do so as it made more sense to me,
  • I consider activity from both clients and jupyter app, though not sure if the latter is explicitly necessary,
  • I do not support "state transition" (like the existing check_idle does) as it didn't seem necessary.

I've added a basic test -- though it's rather crude, I'm happy to accept a suggestion how to do it differently.

  • Tests added / passed
  • Passes pre-commit run --all-files

To automatically shut down the cluster in case no client heartbeats
and no computation running or scheduled. Similar to existing idle
timeout, but more convenient for ad hoc clusters
@tmi tmi requested a review from fjetter as a code owner July 10, 2024 17:44
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 26m 33s ⏱️ + 8m 2s
 4 084 tests + 1   3 968 ✅ + 5    112 💤 ±0  4 ❌  - 4 
55 244 runs  +14  52 805 ✅ +20  2 434 💤 ±0  5 ❌  - 6 

For more details on these failures, see this check.

Results for commit 6a6b445. ± Comparison against base commit 8564dc7.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idle timeout without client attached
2 participants