fixes to run using dart 2.1.0-dev #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxHorstmann
approved these changes
Sep 11, 2018
|
Nope happy to accept any PR's on it. Since this project is effectively unmaintained, @juliovedovatto would you also like to become a maintainer of it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Related to #5)
Few days ago, Dart version updated from
2.0.xto2.1.0-dev.This major updated broke a huge list of dart packages (do a google search and I'll see).
Dart is strict restrictive about version. If you not declare environment
sdkinpubspec.yaml, Dart will assume2.0by default.I updated
pubspec.yamlto fix that and changed dependency package, sinceunittestis deprecated and the author recommends to usetestinstead.I hope it's okay for you.
Thanks!
PS: If you accept my pul request, pls update package in pub.dartlang.org too.