Adapt paths for different development environments #336
+27
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujzs
requested changes
Jan 8, 2025
| @@ -31,7 +31,7 @@ environment: | |||
| sdk: '^$sdkVersion' | |||
| dependencies: | |||
| web: | |||
| path: ${Directory.current.path} | |||
| path: ${p.current.replaceAll(r'\', '/')} | |||
There was a problem hiding this comment.
I think Directory.current.uri.toFilePath() makes more sense here than us manually modifying the path.
| @@ -17,6 +17,7 @@ | |||
| `HTMLIFrameElement.contentWindowCrossOrigin`, `Window.openCrossOrigin`, | |||
| `Window.openerCrossOrigin`, `Window.topCrossOrigin`, | |||
| and `Window.parentCrossOrigin`. | |||
| - Forced test `pubspec.yaml` web path to be POSIX-like path. | |||
There was a problem hiding this comment.
I don't think there needs to be a changelog entry here as it doesn't affect users, just our own testing.
| @@ -14,8 +14,9 @@ Future<void> main(List<String> args) async { | |||
| final offline = args.length == 1 && args.first == '--offline'; | |||
|
|
|||
| // clone the repo | |||
| final repoDir = | |||
| Directory(Platform.script.resolve('../.dart_tool/mdn_content').path); | |||
| final repoUri = Platform.script.resolve('../.dart_tool/mdn_content'); | |||
There was a problem hiding this comment.
We can just inline these instead of introducing variables that are never used otherwise. This applies everywhere else where we introduce a <>Uri variable just to be wrapped by a p.context.fromUri call immediately after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #335
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.