Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renames where the type doesn't exist anymore #334

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −12
Open

Remove renames where the type doesn't exist anymore #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cefc48
Remove renames where the type doesn't exist anymore
maple135790 Jan 3, 2025
d0672a4
add changes to CHANGELOG.md
maple135790 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
`HTMLIFrameElement.contentWindowCrossOrigin`, `Window.openCrossOrigin`,
`Window.openerCrossOrigin`, `Window.topCrossOrigin`,
and `Window.parentCrossOrigin`.
- Removed renames `UnderlyingSource` and `UnderlyingSourceBase` where the types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the other PR that this should go in a new 1.2.0-wip (although this can be addressed after the other PR merges).

don't exist.

## 1.0.0

Expand Down
9 changes: 0 additions & 9 deletions web/lib/fix_data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,15 +1187,6 @@ transforms:
changes:
- kind: 'rename'
newName: 'HTMLUListElement'
# UnderlyingSourceBase => UnderlyingSource
- title: "Rename to 'UnderlyingSource'"
date: 2024-01-12
element:
uris: [ 'package:web/web.dart' ]
class: 'UnderlyingSourceBase'
changes:
- kind: 'rename'
newName: 'UnderlyingSource'
# UnknownElement => HTMLUnknownElement
- title: "Rename to 'HTMLUnknownElement'"
date: 2024-01-12
Expand Down
1 change: 0 additions & 1 deletion web/renames.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@
| TrackElement | HTMLTrackElement |
| TrustedUrl | |
| UListElement | HTMLUListElement |
| UnderlyingSourceBase | UnderlyingSource |
| UnknownElement | HTMLUnknownElement |
| Url | URL |
| UrlSearchParams | URLSearchParams |
Expand Down
1 change: 0 additions & 1 deletion web/test_fixes/renames.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ late TimeElement $138;
late TitleElement $139;
late TrackElement $140;
late UListElement $143;
late UnderlyingSourceBase $144;
late UnknownElement $145;
late Url $146;
late UrlSearchParams $147;
Expand Down
1 change: 0 additions & 1 deletion web/test_fixes/renames.dart.expect
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ late HTMLTimeElement $138;
late HTMLTitleElement $139;
late HTMLTrackElement $140;
late HTMLUListElement $143;
late UnderlyingSource $144;
late HTMLUnknownElement $145;
late URL $146;
late URLSearchParams $147;
Expand Down
Loading