-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing FileReader event getters #333
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@maple135790 – need you to sign the CLA, please! #333 (comment) |
Should also update the changelog! |
Sorry for not signing CLA at the first time, I have already sign the CLA and finished rescan, but the #333 (comment) is still showing 🤔 |
The Edit: Sorry, just noticed, but the changelog entry should go under a new section |
web/CHANGELOG.md
Outdated
@@ -17,6 +17,8 @@ | |||
`HTMLIFrameElement.contentWindowCrossOrigin`, `Window.openCrossOrigin`, | |||
`Window.openerCrossOrigin`, `Window.topCrossOrigin`, | |||
and `Window.parentCrossOrigin`. | |||
- Added missing `FileReader` event getters: `onAbort`, `onError`, `onLoad`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go under a new section 1.2.0-wip
as 1.1.0
has been released already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thank you for the mention
fixed in 0e77396
#330
add
onLoad
event and some other events shown on MDN, such asonLoadStart
,onProgress
etc.minor detail: fix the extension method name typo
FileReaderEventGEtters
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.