Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing FileReader event getters #333

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maple135790
Copy link

#330

add onLoad event and some other events shown on MDN, such as onLoadStart, onProgress etc.

minor detail: fix the extension method name typo FileReaderEventGEtters


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

google-cla bot commented Jan 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kevmoo
Copy link
Member

kevmoo commented Jan 6, 2025

@maple135790 – need you to sign the CLA, please! #333 (comment)

@kevmoo
Copy link
Member

kevmoo commented Jan 6, 2025

Should also update the changelog!

@maple135790
Copy link
Author

@maple135790 – need you to sign the CLA, please! #333 (comment)

Sorry for not signing CLA at the first time, I have already sign the CLA and finished rescan, but the #333 (comment) is still showing 🤔

@srujzs
Copy link
Contributor

srujzs commented Jan 8, 2025

The cla/google check seems to be green, so I believe you should be good.

Edit: Sorry, just noticed, but the changelog entry should go under a new section 1.2.0-wip. 1.1.0 has already been released.

web/CHANGELOG.md Outdated
@@ -17,6 +17,8 @@
`HTMLIFrameElement.contentWindowCrossOrigin`, `Window.openCrossOrigin`,
`Window.openerCrossOrigin`, `Window.topCrossOrigin`,
and `Window.parentCrossOrigin`.
- Added missing `FileReader` event getters: `onAbort`, `onError`, `onLoad`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under a new section 1.2.0-wip as 1.1.0 has been released already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thank you for the mention
fixed in 0e77396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants