-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mono_repo for package:web #288
Conversation
Splits package:web into two packages: - package:web - package:web_generator (not published) The latter contains our tooling to generate the former, and used to be the tool directory. Refactors code to point to new paths and moves directories like third_party to their appropriate locations. Moves the CI configurations to mono_repo.yaml and mono_pkg.yaml files, and is now generated as dart.yml.
But...why? What does this get us? |
This came up with analysis of an external PR. Analysis with the latest dev version has started failing due to the generator using The solutions were:
As a bonus, if we wanted, we could publish the generator as a separate package so users can use it to generate definitions that we don't emit in this package. This was discussed in #145 before, but is not really the primary goal of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Splits package:web into two packages:
The latter contains our tooling to generate the former, and used to be the tool directory.
Platform.script.resolve
so that thebin/
files can be run from anywhere instead of within that directory)third_party
and tests to their new appropriate locationsmono_repo.yaml
andmono_pkg.yaml
files and is now generated asdart.yml
(used to bebuild.yaml
)pubspec.yaml
, and CHANGELOG filesJSArrayExtension
which is no longer needed.Refactors code to point to new paths and moves directories like third_party to their appropriate locations. Moves the CI configurations to mono_repo.yaml and mono_pkg.yaml files, and is now generated as dart.yml.