-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip some wasm tests #2285
Skip some wasm tests #2285
Conversation
Try to unblock CI. Some wasm tests are failing to load without a clear failure message.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Chrome tests are failing to start up, and firefox tests are not running any test cases.
Work around missing firefox tests by adding tests that will run.
compilers: [dart2wasm] | ||
platforms: | ||
# TODO(https://github.com/dart-lang/test/issues/1790) - unskip | ||
# - chrome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked issue is two years old and the link to the CI run in the issue is dead. Do we know if it's still relevant?
There shouldn't be any failures on Chrome. There only a few bugs in async*
but other than that it work, and if it doesn't we should fix it instead.
What is this fixing exactly? The referenced issue in the comments is 2 years old and referring to a time when dart2wasm could run hello world plus a few other programs. It's feature complete now with only a few known bugs. The CI runs in the main branch are also all green. |
This was just trying to unblock CI for the failures with the old SDK. I reused the stale issue instead of filing a new one just so we had something to track unskipping them. The failures are resolved by #2286 so I'll close this one. We might still want to look in to the weird behavior on firefox. |
Skip some wasm integration tests in chrome and on windows.
Add a
dart2js
test to run in firefox on linux which can start, butcurrently fails because it runs no test cases.