Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New layout implementation and sidenav design #6344

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Jan 21, 2025

  • Updates the sidenav static generation logic to match flutter/website for improved build performance and consistency. Also removes the need for specifying match-page-url-exactly on directory index pages.
    • This changes the 11ty related filters.ts and eleventyComputed.js files. These changes have already been reviewed and been in use by flutter/website for a while.
  • Redesigns the sidenav for improved accessibility and reducing dependence on Bootstrap.
  • Reimplements the site layout in preparation for Bootstrap removal and improving scrolling.
  • Removes a bunch of now unneeded logic and styles, further supporting the later removal of Bootstrap.

Fixes #5791
Fixes #5789
Contributes to #4164
Contributes to #3849
Prepares for #2625

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 21, 2025

Visit the preview URL for this PR (updated for commit f75dc94):

https://dart-dev--pr6344-feat-migrated-layout-and-sidenav-hkny0dr0.web.app

@parlough parlough requested review from johnpryan, ericwindmill and MaryaBelanger and removed request for johnpryan January 21, 2025 14:45
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you Parker!

@MaryaBelanger MaryaBelanger merged commit 736baa3 into main Jan 21, 2025
9 of 10 checks passed
@parlough parlough deleted the feat/migrated-layout-and-sidenav branch January 21, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust left menu to work at 200% magnification Add name and description to left menu
3 participants