Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for WebSockets #379

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Martoxdlol
Copy link

Hello!
I added support for proxying websockets. It is implemented checking the 'Upgrade' header and using shelf_web_socket and web_socket_channel packages.

@google-cla
Copy link

google-cla bot commented Sep 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Martoxdlol
Copy link
Author

Hello, could someone review this?

@kevmoo
Copy link
Member

kevmoo commented Jan 27, 2024

@natebosch @devoncarew @brianquinlan – thoughts?

@natebosch
Copy link
Member

This package currently does not have imports to dart:io. I don't know that there is utility in running this code anywhere without dart:io, but adding the new dependencies and the new platform restriction is probably enough reason to not add this support.

I wonder if there is some way can make this pluggable.

Or is the import 'package:web_socket_channel/io.dart'; required - maybe we can use the cross platform import for connecting the socket?

@Martoxdlol
Copy link
Author

This package currently does not have imports to dart:io. I don't know that there is utility in running this code anywhere without dart:io, but adding the new dependencies and the new platform restriction is probably enough reason to not add this support.

I wonder if there is some way can make this pluggable.

Or is the import 'package:web_socket_channel/io.dart'; required - maybe we can use the cross platform import for connecting the socket?

Hmmm I didn't think about that. I will look for another solution.

Maybe I can make a separate package that adds websockets or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants