Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the response method consistent #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wesolowski
Copy link

@wesolowski wesolowski commented Aug 17, 2023

The methods ok, unauthorized, forbidden, notFound first have body as a parameter, and then the other parameters must be defined,

The methods internalServerError and badRequest are different, all parameters are in {}

What you might be able to do is to change the parameter definition of the anadere method?

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

The methods ok, unauthorized, forbidden, notFound first have body as a parameter, and then the other parameters must be defined, 

The methods internalServerError and badRequest are different, all parameters are in {}

What you might be able to do is to change the parameter definition of the anadere method?
@google-cla
Copy link

google-cla bot commented Aug 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant