-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Adding absolute paths to build.py and gn.py #59798
base: main
Are you sure you want to change the base?
Conversation
Changed build.py and gn.py to allow for differing absolute paths. This case may occurr when building dart-sdk under Linux signed-off-by: Thomas Rahimi <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/402282 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
Added another relative path variable to allow build in non standard environments signed-off-by: Thomas Rahimi <[email protected]>
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
Changed build.py and gn.py to allow for differing absolute paths. This case may occur when building dart-sdk under Linux
signed-off-by: Thomas Rahimi [email protected]