Skip to content

Commit

Permalink
[VM] Minor cleanup
Browse files Browse the repository at this point in the history
TEST=ci

Change-Id: I8b7b3533326be7572ccfdb1ea7f81c6f154e9030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343341
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>
  • Loading branch information
a-siva authored and Commit Queue committed Dec 21, 2023
1 parent 94c8d34 commit a0c9333
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
4 changes: 0 additions & 4 deletions runtime/bin/dartdev_isolate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,6 @@ Utils::CStringUniquePtr DartDevIsolate::TryResolveDartDevSnapshotPath() {
return TryResolveArtifactPath("dartdev.dart.snapshot");
}

Utils::CStringUniquePtr DartDevIsolate::TryResolveDartDevKernelPath() {
return TryResolveArtifactPath("dartdev.dill");
}

void DartDevIsolate::DartDevRunner::Run(
Dart_IsolateGroupCreateCallback create_isolate,
char** packages_file,
Expand Down
3 changes: 0 additions & 3 deletions runtime/bin/dartdev_isolate.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ class DartDevIsolate {

static bool should_run_dart_dev() { return should_run_dart_dev_; }

// Attempts to find the path of the DartDev kernel file.
static Utils::CStringUniquePtr TryResolveDartDevKernelPath();

// Attempts to find the path of the DartDev snapshot.
static Utils::CStringUniquePtr TryResolveDartDevSnapshotPath();

Expand Down
2 changes: 1 addition & 1 deletion runtime/bin/main_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -372,11 +372,11 @@ static Dart_Isolate IsolateSetupHelper(Dart_Isolate isolate,
CHECK_RESULT(result);
}

#if !defined(DART_PRECOMPILED_RUNTIME)
// Disable pausing the DartDev isolate on start and exit.
const char* isolate_name = nullptr;
result = Dart_StringToCString(Dart_DebugName(), &isolate_name);
CHECK_RESULT(result);
#if !defined(DART_PRECOMPILED_RUNTIME)
if (strstr(isolate_name, DART_DEV_ISOLATE_NAME) != nullptr) {
Dart_SetShouldPauseOnStart(false);
Dart_SetShouldPauseOnExit(false);
Expand Down

0 comments on commit a0c9333

Please sign in to comment.