Detect Swiftpm support #1412
Detect Swiftpm support #1412
Conversation
|
cc @loic-sharma. |
There was a problem hiding this comment.
LGTM, if @loic-sharma is happy.
I'm a little unsure if darwin/ should only be attempted when sharedDarwinSource: true is the case.
lib/src/tag/tagger.dart
Outdated
| final specificPackageSwiftFile = | ||
| path.join(darwinOs, packageName, 'Package.swift'); | ||
| final genericPackageSwiftFile = | ||
| path.join('darwin', packageName, 'Package.swift'); |
There was a problem hiding this comment.
@loic-sharma, the only documentation I can find for things under flutter.plugin is the guide guide. It doesn't even default to telling people to use Package.swift, it does reference swiftpm docs though.
I see that the docs suggest that you can use properties like:
ffiPlugin, and,sharedDarwinSource.
Under flutter.plugin.platforms.ios and flutter.plugin.platforms.macos.
Does ffiPlugin only affect method channels, and not affect the need for a podspec or Package.swift? (I'm not sure entirely sure, just guessing)
Is sharedDarwinSource: true the only circumstance under which we should look in darwin/<packageName>/Package.swift ? (I'm suspecting so)
It would probably be useful with Flutter plugin reference documentation.
Similar to pubspec reference docs covering the properties under flutter.plugin and what files they imply exist.
There was a problem hiding this comment.
Does
ffiPluginonly affect method channels, and not affect the need for a podspec orPackage.swift? (I'm not sure entirely sure, just guessing)
From my understanding, a plugin can support CocoaPods & SwiftPM and also be an ffiPlugin. For example: https://docs.flutter.dev/platform-integration/ios/c-interop#open-source-third-party-library
cc @dcharkes to confirm.
Is
sharedDarwinSource: truethe only circumstance under which we should look indarwin/<packageName>/Package.swift? (I'm suspecting so)
Yup that's correct.
If flutter.plugin.platforms.ios.sharedDarwinSource is true, we should check the darwin/<plugin name>/Package.swift. If this config is false or omitted, we should check the ios/<plugin name>/Package.swift.
Keep in mind that iOS and macOS have separate sharedDarwinSource configs. It's possible that only one platform uses the darwin directory. So if flutter.plugin.platforms.ios.sharedDarwinSource is true but flutter.plugin.platforms.macos.sharedDarwinSource is omitted, we should use the darwin directory for iOS but the macos directory for macOS.
It would probably be useful with Flutter plugin reference documentation.
Similar to pubspec reference docs covering the properties underflutter.pluginand what files they imply exist.
This is an excellent idea. I filed this issue: flutter/website#11334
There was a problem hiding this comment.
@sigurdm should we take sharedDarwinSource into account?
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
|
This is awesome, thanks for adding this! 💙 |
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>
Fixes #1402