Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Flip native_x packages back to wip #1866

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[infra] Flip native_x packages back to wip #1866

merged 2 commits into from
Jan 6, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jan 6, 2025

We have published new versions of the following packages:

  • package:native_assets_builder
  • package:native_assets_cli
  • package:native_toolchain_c

So we can switch the repository back to "development mode" and use path dependencies.

@github-actions github-actions bot removed the type-infra A repository infrastructure change or enhancement label Jan 6, 2025
@dcharkes dcharkes changed the title [native_*] Flip packages back to wip [infra] Flip native_x packages back to wip Jan 6, 2025
@dcharkes dcharkes requested a review from mkustermann January 6, 2025 13:34
Copy link

github-actions bot commented Jan 6, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_assets_builder/test_data/native_dynamic_linking/bin/native_dynamic_linking.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Jan 6, 2025

Coverage Status

coverage: 87.527%. remained the same
when pulling 2085cad on flip-back-to-dev
into ab7872c on main.

@dcharkes dcharkes merged commit 0f9cb0b into main Jan 6, 2025
33 of 35 checks passed
@dcharkes dcharkes deleted the flip-back-to-dev branch January 6, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants