-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a top-level .gitignore
#1383
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ❗
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. This check can be disabled by tagging the PR with |
There are many Should we also remove all nested gitignores? (Or at least remove all entries that are overlapping with the toplevel one?) And what about gitignores in examples and test projects which are likely to be verbatim copied. Should we update those to be whatever is currently the standard in flutter / dart templates? |
Agreed. I'll do that in the next commit. |
Commit or PR? |
Commit on the same PR. |
@mosuem Any guidance from an ecosystem perspective on how to structure gitignores in mono repos and in example projects? |
No. I personally would use a top-level |
6882aaf
to
5f147bc
Compare
5f147bc
to
64c54c6
Compare
Merging as the only files changed are |
Removed remaining
pubspec.lock
s.Copied the
.gitignore
from https://github.com/flutter/packages/blob/main/.gitignore.Removed extra
.gitignore
files.Motivation: it does not make sense to have
pubspec.lock
, butexample
's default.gitignore
does not ignore it as it's technically an application not a package.