Skip to content

Commit

Permalink
Fix flutter health wf (#1787)
Browse files Browse the repository at this point in the history
* Fix flutter health wf

* change paths

* use branch

* Ignore swiftgen

* Ignore ffigen

* disable jnigen

* Dont ignore anymore

* ignore swiftgen

* Fix paths

* use package from path

* Don't check jnigen

* Add changelog

* Dont check swift2objc

* Use main channel

* Rev versions according to breaking change policy

* Rev version even more

* Run on all branches
  • Loading branch information
mosuem authored Jan 2, 2025
1 parent 2251646 commit beccf58
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 35 deletions.
17 changes: 9 additions & 8 deletions .github/workflows/health.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
name: Health
on:
pull_request:
branches: [ main ]
# Remove paths after https://github.com/bmw-tech/dart_apitool/issues/177 is addressed.
paths:
- "pkgs/ffi/**"
- "pkgs/native_assets_builder/**"
- "pkgs/native_assets_cli/**"
- "pkgs/native_toolchain_c/**"
- ".github/workflows/health.yaml"
- "pkgs/**"
types: [opened, synchronize, reopened, labeled, unlabeled]
jobs:
health:
uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
with:
coverage_web: false
# TODO(https://github.com/dart-lang/native/issues/1242): Add coverage back.
checks: "version,changelog,license,do-not-submit,breaking,leaking"
use-flutter: true
sdk: master
checks: "changelog,license,do-not-submit,breaking,leaking"
flutter_packages: "pkgs/ffigen,pkgs/jni,pkgs/jnigen,pkgs/objective_c"
ignore_license: "**.g.dart"
ignore_coverage: "**.mock.dart,**.g.dart"
ignore_packages: "pkgs/swiftgen,pkgs/jnigen,pkgs/swift2objc"
sdk: dev
channel: master
permissions:
pull-requests: write
21 changes: 0 additions & 21 deletions .github/workflows/health_flutter.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion pkgs/ffigen/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 16.0.1-wip
## 17.0.0-wip

- Ensure that required symbols are available to FFI even when the final binary
is linked with `-dead_strip`.
Expand Down
4 changes: 4 additions & 0 deletions pkgs/ffigen/example/shared_bindings/generate.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:io';

import 'package:cli_util/cli_util.dart';
Expand Down
2 changes: 1 addition & 1 deletion pkgs/ffigen/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# BSD-style license that can be found in the LICENSE file.

name: ffigen
version: 16.0.1-wip
version: 17.0.0-wip
description: >
Generator for FFI bindings, using LibClang to parse C, Objective-C, and Swift
files.
Expand Down
1 change: 1 addition & 0 deletions pkgs/jnigen/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Fixed a potential name collision when generating in multi-file mode.
- Added the ability to add user-defined visitors to config. Currently only
capable of excluding classes, methods, and fields.
- Add dependency override for `package:jni` instead of the path dependency.

## 0.12.2

Expand Down
7 changes: 5 additions & 2 deletions pkgs/jnigen/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ dependencies:
dev_dependencies:
build_runner: ^2.4.12
dart_flutter_team_lints: ^3.2.0
jni:
path: ../jni
jni: ^0.12.2
json_serializable: ^6.8.0
test: ^1.25.8

dependency_overrides:
jni:
path: ../jni
2 changes: 1 addition & 1 deletion pkgs/objective_c/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 4.0.1-wip
## 4.1.0-wip

- Reduces the chances of duplicate symbols by adding a `DOBJC_` prefix.
- Ensure that required symbols are available to FFI even when the final binary
Expand Down
2 changes: 1 addition & 1 deletion pkgs/objective_c/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

name: objective_c
description: 'A library to access Objective C from Flutter that acts as a support library for package:ffigen.'
version: 4.0.1-wip
version: 4.1.0-wip
repository: https://github.com/dart-lang/native/tree/main/pkgs/objective_c
issue_tracker: https://github.com/dart-lang/native/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Aobjective_c

Expand Down

0 comments on commit beccf58

Please sign in to comment.