Add handshake to determine wire encoding and protocol. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
protocol-version
branch
4 times, most recently
from
ba20d44 to
a67c0cc
Compare
davidmorgan
force-pushed
the
protocol-version
branch
from
a67c0cc to
2008d98
Compare
jakemac53
reviewed
Sep 12, 2024
jakemac53
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now the host simply has one encoding+protocol that it wants to use and it will only use that.
The next PR in this area should be able to add support for actual protocol breaking changes.
This is an important thing to get right so it should come with a design doc :)
I don't think anything else is blocked on this so it's relatively low priority.