Extend golden tests to optionally cover augmentations. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
more-goldens
branch
2 times, most recently
from
21448e7 to
c04ed1d
Compare
davidmorgan
force-pushed
the
more-goldens
branch
from
c04ed1d to
9297a04
Compare
jakemac53
approved these changes
Sep 10, 2024
|
|
||
| expect(introspectionMacroOutput, introspectionGolden, | ||
| reason: updateGoldens | ||
| ? null |
There was a problem hiding this comment.
Consider maybe a message like --> Goldens will be updated, run again and test should pass
| late File goldenFile; | ||
| late Map<String, Object?> golden; | ||
| Map<String, Object?>? macroOutput; | ||
| File? introspectionGoldenFile; |
There was a problem hiding this comment.
At some point we might want to try and share the logic for these tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.