add scope and isStatic to QualifiedName, as well as parsing and a URI format #101
Conversation
| Property('name', | ||
| type: 'String', | ||
| description: 'The name of the declaration to look up.'), | ||
| Property('isStatic', |
There was a problem hiding this comment.
I guess this will probably end up as an enum, since we might want to distinguish more types of thing (e.g. getter vs setter vs field), and more might arrive later. Maybe a TODO since it's easy to change for now?
There was a problem hiding this comment.
I don't think it ever matters whether it is a getter/setter/field for the purposes of this object, it is just telling you how to look up a declaration unambiguously, which does require knowing if it should be looked up in the static or instance member scope.
There was a problem hiding this comment.
Doesn't matter for right now, but I was thinking of a case where you have e.g. a subclass with a setter and superclass with a getter; you need to say setter or getter to disambiguate between the two. It's a bit of an awkward corner :) anyway, we can figure that out later if needed. Thanks.
There was a problem hiding this comment.
Oh for setters, the name should probably be followed by an =. At least that is how most of the other tooling deals with this afaik. cc @johnniwinther @scheglov for comment.
Although in terms of macros, maybe we do want to distinguish here, because we don't really want to include the = when outputting code. So I think the existing macro stuff does not include it.
Closes #100 - Adds `model` field to AugmentRequest, with implementations to pass it (although, these use a host side query). - Expose the `hostService` from the `MacroHost` (used to do the query) - Adds a `Model` parameter to all macro methods (typed as `Object` for right now for most of them, as we don't have better types yet). - Make all fields on AugmentRequest required (this simplified implementations, but lmk if you want me to revert this). - Rename the `Model.qualifiedNameOfMember` extension to `qualifiedNameOf` generalizing and fixing it: - Now it actually does what it says 🤣 (it used to return just the qualified name of the type the member is declared in I think?), there was in any case no way to represent members with qualified names, see #101 which adds that. - It now throws for anything other than types, since they can't be referenced - It just accepts a `Map<String, Object?>` now which is the only thing we can generalize on for the moment, but see #103 for one possible workaround. - Fixes up tests and removes expected request/response from the client for the model
Closes #96, I think for libraries we will want just a Uri essentially, since they aren't first class objects in Dart, you can't refer directly to them.