New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanup from removal of SpecialClasses #3955

Merged

srawlins merged 1 commit into dart-lang:main from srawlins:specials-cleanup

Jan 2, 2025

Member

srawlins commented Jan 2, 2025

We stopped using "special classes" and so stopped using the addingSpecials parameter of _discoverLibraries.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          More cleanup from removal of SpecialClasses

abee441

Member Author

srawlins commented Jan 2, 2025

CC @dart-lang/analyzer-team

scheglov approved these changes

View reviewed changes

srawlins merged commit c8dd09c into dart-lang:main

9 checks passed

srawlins deleted the specials-cleanup branch

January 2, 2025 22:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet