Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the breaking API change health check #3760

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/health.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ jobs:
health:
uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
with:
checks: "version,changelog,do-not-submit"
checks: "version,changelog,do-not-submit,breaking"
fail_on: "version,changelog,do-not-submit,breaking"
warn_on: "license,coverage,leaking"
ignore_license: "**.g.dart"
sdk: dev
permissions:
Expand Down
4 changes: 2 additions & 2 deletions _test/lib/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

import 'package:web/web.dart';

void startApp({String? text}) {
text ??= 'Hello World!';
void startApp({required String text}) {
// text ??= 'Hello World!';
var component = HTMLDivElement()..text = text;
document.body!.append(component);
}
2 changes: 1 addition & 1 deletion _test/test/hello_world_deferred_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import 'package:web/web.dart';
import 'common/message.dart' deferred as m;

void main() {
setUp(startApp);
setUp(() => startApp(text: 'Hello World!'));

tearDown(() {
document.body!.innerHTML = ''.toJS;
Expand Down
2 changes: 1 addition & 1 deletion _test/test/hello_world_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import 'package:web/web.dart';
import 'common/message.dart';

void main() {
setUp(startApp);
setUp(() => startApp(text: 'Hello World!'));

tearDown(() {
document.body!.innerHTML = ''.toJS;
Expand Down
2 changes: 2 additions & 0 deletions build_web_compilers/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 4.2.0

## 4.1.0-beta.1

- Fix loading compiled modules from subdirectories.
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/lib/builders.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import 'src/sdk_js_compile_builder.dart';
import 'src/sdk_js_copy_builder.dart';

// Shared entrypoint builder
Builder webEntrypointBuilder(BuilderOptions options) =>
Object webEntrypointBuilder(BuilderOptions options) =>
WebEntrypointBuilder.fromOptions(options);

// Ddc related builders
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_web_compilers
version: 4.1.0-beta.1
version: 4.2.0
description: Builder implementations wrapping the dart2js and DDC compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers
# This package can't be part of the workspace because it requires a very recent
Expand Down
Loading