This repository has been archived by the owner on Dec 6, 2017. It is now read-only.
Fixes classes with the same name in different libraries. #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated code will sometimes contain a reference to TypeLiteral, but it doesn't include the neccessary import.
Currently, key names are only based on the name of the type. However, it posible to have multiple types with the same name in different libraries. This extends the name of the key to also include the library it was imported from.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, key names are only based on the name of the type. However, it
posible to have multiple types with the same name in different
libraries. This extends the name of the key to also include the library
it was imported from.