Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actors API] update err desc to be more explicit #643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Oct 23, 2024

Ran into some errors with using the Actors API & reminders. This PR is a nice to have making it explicit to newbie actor users what the error means.

This PR fixes one of the issues, which I also had locally and confirm resolves the err:

== APP == 2024/10/22 13:54:53 http: superfluous response.WriteHeader call from [github.com/dapr/go-sdk/service/http.(*Server).registerBaseHandler.func6](http://github.com/dapr/go-sdk/service/http.(*Server).registerBaseHandler.func6) (topic.go:214)

@cicoyle cicoyle requested review from a team as code owners October 23, 2024 14:40
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.48%. Comparing base (27248ba) to head (d3077c1).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
actor/manager/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   58.04%   62.48%   +4.44%     
==========================================
  Files          55       56       +1     
  Lines        3568     4145     +577     
==========================================
+ Hits         2071     2590     +519     
- Misses       1375     1428      +53     
- Partials      122      127       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

actor/manager/manager.go Outdated Show resolved Hide resolved
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Cassie Coyle <[email protected]>
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants