Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: state_manger_test.go #486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sadath-12
Copy link
Contributor

Covers test cases for actor/state/state_manager.go

@sadath-12 sadath-12 requested a review from a team as a code owner December 16, 2023 07:01
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a WIP?

@sadath-12
Copy link
Contributor Author

sadath-12 commented Dec 23, 2023

Is this a WIP?

Nope its done . Any further suggestions ?

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f7b59) 70.08% compared to head (3eba237) 70.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files          35       35           
  Lines        2841     2841           
=======================================
  Hits         1991     1991           
  Misses        738      738           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sadath-12 <[email protected]>
@mikeee
Copy link
Member

mikeee commented Jan 6, 2024

Is this a WIP?

Nope its done . Any further suggestions ?

Apologies, I have a bad habit of reviewing when it's late - I'm not sure if I'm reading this correctly but I don't think this PR implements any testing as intended. You're essentially declaring a mock, telling it what to expect (and return) and then giving it what it expects. There is nothing being passed back to the test runtime either.

@sadath-12
Copy link
Contributor Author

Then I think we should either correct or implement the mock server properly then we can extend more tests as this pr was just meant to add some minimal tests if we see the issue description also other tests related to statemanager in this repo are not doing anything

@mikeee
Copy link
Member

mikeee commented Jan 7, 2024

I'm not sure what you mean, if I'm reading the contents of this PR correctly - no tests are added.

What other tests are you referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants