-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: state_manger_test.go #486
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: sadath-12 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a WIP?
Nope its done . Any further suggestions ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 35 35
Lines 2841 2841
=======================================
Hits 1991 1991
Misses 738 738
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sadath-12 <[email protected]>
Apologies, I have a bad habit of reviewing when it's late - I'm not sure if I'm reading this correctly but I don't think this PR implements any testing as intended. You're essentially declaring a mock, telling it what to expect (and return) and then giving it what it expects. There is nothing being passed back to the test runtime either. |
Then I think we should either correct or implement the mock server properly then we can extend more tests as this pr was just meant to add some minimal tests if we see the issue description also other tests related to statemanager in this repo are not doing anything |
I'm not sure what you mean, if I'm reading the contents of this PR correctly - no tests are added. What other tests are you referring to? |
Covers test cases for
actor/state/state_manager.go