Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github bot update - allow Dapr maintainers to apply labels via bot comments #4417

Open
wants to merge 5 commits into
base: v1.14
Choose a base branch
from

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

In addition, please fill out the following to help reviewers understand this pull request:

Description

The bot already allows users of issues to use an "/assign" command to assign themselves an issue if they aren't assigned already. I left that functionality alone and in-place as it applies to all users and works well enough.

But this PR augments that capability. Rather than taking the approach used in other Dapr repos of lists of users, this instead uses a third-party action (I read through the source and see nothing suspicious in there) to determine whether the user that has created the comment is a member of any of the Dapr maintainer org teams.

If so, it executes a separate github-script action that only executes if the following constraints are true:

  • The user is a member of any Dapr organization maintainer team
  • The comment was made on a PR
  • The comment matches any of the allowed comments (listed later on)

If so, the associated label will be appended to the PR if not already present. I read through the labels available in dapr/docs and came up with the following list, which I think is reasonable for maintainers of other repos to want to use:

Slash command Label
/do-not-merge do-not-merge
/waiting-on-pr waiting-on-code-pr
/missing-docs feature-in-release-no-docs
/required release-requirement

Finally, I have no idea how to test this out except by committing and giving it a whirl. If anyone has a clue how to otherwise test it, I'm all ears, but I can at least attest to the fact that the Firefox console had no objections to the syntax of the script.

Issue reference

N/A - raised by myself on Discord.

@WhitWaldo WhitWaldo requested review from a team as code owners November 2, 2024 01:54
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 10, 2024
@WhitWaldo
Copy link
Contributor Author

Don't merge this yet - replacing with another, but when we talked last week, we weren't yet entirely sure which repository to put it in, so this might be superseded by that.

@github-actions github-actions bot removed the stale label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant