Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary dependency, updating dependency, and improving docs #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ikr4-m
Copy link

@ikr4-m ikr4-m commented Jul 11, 2022

Here's what I made in this pull request:

  1. Updating dependency because it has a bunch of vuln.
  2. Removing copyfiles deps and set resolveJsonModule to make sure all of JSON file imported without using any deps aside from TypeScript
  3. Make your docs have a little colors in examples.

Note (No. 2)

We can using this script to copy all JSON files from src to dist if resolveJsonModule is disabled:

#!/bin/sh

# Remove dist file
rm -rf ./dist

# Compile TypeScript to Javascript
tsc

# Find any file with .json extension in src and make some system execute using awk
find ./src/*/.json | awk '{system(print "cp " $1 " ./dist" substr($1, 6));}'

But I worry about developer that using Mac OS (GNU GAWK is totally different from BSD GAWK) so I just enabling resolveJsonModule and including all JSON files in tsconfig.

@ikr4-m ikr4-m changed the title feat(bounty): Remove unecessary dependency, updating dependency, and improving docs Remove unecessary dependency, updating dependency, and improving docs Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant