Skip to content

Commit

Permalink
Merge pull request onflow#5157 from onflow/petera/fix-without-netgo-s…
Browse files Browse the repository at this point in the history
…emver

[CI] Use build tag for without-netgo
  • Loading branch information
peterargue authored Jan 16, 2024
2 parents 3f6c4c1 + 1d5c8e0 commit f040031
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ifeq (${IMAGE_TAG},)
IMAGE_TAG := ${SHORT_COMMIT}
endif

IMAGE_TAG_NO_NETGO := $(IMAGE_TAG)-without-netgo
IMAGE_TAG_NO_NETGO := $(IMAGE_TAG)+without-netgo

# Name of the cover profile
COVER_PROFILE := coverage.txt
Expand Down
5 changes: 5 additions & 0 deletions engine/execution/ingestion/stop/stop_control_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -865,4 +865,9 @@ func Test_StopControlWorkers(t *testing.T) {
func TestPatchedVersion(t *testing.T) {
require.True(t, semver.New("0.31.20").LessThan(*semver.New("0.31.21")))
require.True(t, semver.New("0.31.20-patch.1").LessThan(*semver.New("0.31.20"))) // be careful with this one
require.True(t, semver.New("0.31.20-without-netgo").LessThan(*semver.New("0.31.20")))

// a special build created with "+" would not change the version priority for standard and pre-release versions
require.True(t, semver.New("0.31.20+without-netgo").Equal(*semver.New("0.31.20")))
require.True(t, semver.New("0.31.20-patch.1+without-netgo").Equal(*semver.New("0.31.20-patch.1")))
}

0 comments on commit f040031

Please sign in to comment.