-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen for sparse-dense cross-entropy #919
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add linalg transposeOp - rewrite some EwUnary/Binary Ops to handle matrix and scalar types - use specialized Ops in EwUnary/Binary (e.g. ipowi, fpowi) - add canonicalizer pattern for ceil/floor/round for integer types
- Minor formatting
- rework aggAll codegen - implement aggDim codegen - rework ewUnary/ewBinary codegen - add tests for new codegen (scripts and filecheck) - rename some existing tests for better overview - add some needed kernel instantiations (kernels.json)
- minor refactoring/formatting - fix some typos - general minor polishing
… specific pattern - the pattern sum(sparse * ln(dense @ dense)) with a CSRMatrix and two DenseMatrices is replaced entirely by codegen. This avoids materializing potentially large dense intermediates and fuses the whole pattern. - Added CSRMatrix -> MemRef helper functions/kernels to enable (one-way) interop with MLIR - small changes to CSRMatrix.h to enable helper functions by returning shared pointers to its underlying data arrays - slightly modified rewriteToCallKernelOp, kernelCatalogParser, and compilerUtils to handle single rank MemRefs - Added needed instantiations to kernels.json - Modified existing codegen passes to handle inputs that are not DenseMatrices/scalars (corresponding Ops are now marked as legal if input does not meet requirements) - Todo: add tests
- revert leftover duplicate code from merge - remove use of format for compatibility with docker containers - minor formatting/tidying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a codegen pass to lower the following expression to a fused operator that exploits sparsity
sum(CSRMat * ln(denseLhs @ t(denseRhs)))
.It can be run simply by enabling the codegen pipeline (
--mlir-codegen
) and ensuring the lhs of the elementwise multiplication is a CSRMatrix (currently--select-matrix-repr
) with the corresponding cli flags.By computing the sum directly, the pass not only avoids materializing potentially large dense matrices in the dense, right matrix multiplication, it also only computes the necessary dot products corresponding to non-zero entries in the CSRMatrix. Thus, it uses constant memory and reduces runtime significantly.
An example script to test the results (
--explain mlir_codegen
is optional to show the generated IR):A more thorough description will be given once some tests have been added.