629 kernel functions for dense matrix of strings #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…> struct for std::string and FixedStr16
…ng and FixedStr16
- Renamed test CSV and meta data files. - Removed unnecessary casts of ValueTypeUtils::default_value to the type it already has. - Renamed ValueTypeUtils::default_value to defaultValue. - oneHot-kernel - Removed superfluous additional convenience functions. - Release recoded intermediate. - Made index calculation view-aware. - Reduced the code duplication of the specializations for std::string and FixedStr16 by factoring out the code into a separate function template. - Tidied up BinaryOpCode.h. - Little formatting corrections. - And some more minor things.
- The FixedStr16 buffer no longer requires a null-terminator. - This change optimizes memory usage for FixedStr16 value type.
saminbassiri
force-pushed
the
629-kernel-functions-for-DenseMatrix-of-Strings
branch
from
216c16e to
eb2fe47
Compare
saminbassiri
force-pushed
the
629-kernel-functions-for-DenseMatrix-of-Strings
branch
from
eb2fe47 to
f3b7504
Compare
…s-for-DenseMatrix-of-Strings
- For some reason, the changes made by 4bf6d03 were undone in this PR, even though all other recent commits from main were merged in.
- Renaming of some test cases. - Applying unit test cases for string-values matriced not only to DenseMatrix, but also to the Matrix superclass (works out-of-the-box).
pdamme
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks for this contribution, @saminbassiri. The more kernels are supported/tested on string-valued matrices, the better ;) . Your code looks good to me. I only did some minor changes (test case names etc.). Furthermore, while your unit tests only used the DenseMatrix, they actually also work for the Matrix superclass, so I extended the test cases by that data type. This PR is ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DAPHNE-#629] Add Support for Indexing, Reshape, and Reverse on DenseMatrix of Strings at Kernel Level
Summary
This PR addresses issue #629, extending string processing capabilities in Daphne and building on the progress of PR #797.
Changes:
DenseMatrixof strings at the kernel level.DenseMatrixof strings at the kernel level.DenseMatrixof strings at the kernel level.Testing
DenseMatrix<std::string>andDenseMatrix<FixedStr16>, ensuring the new features function as expected.