-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split fmt and spdlog dependencies #842
Conversation
In order for nvcc (CUDA compiler) to not fail the DAPHNE build after switching to C++20, we introduce fmt as a separate dependency and upgrade the spdlog to the tip of the spdlog default branch as of 2024-10-03 for the time being (we'll switch back to a release once that compiles without troubles) because the released spdlog 1.14.1 did not compile with the newer fmt 11.0.2. Closes #842
3800ebe
to
1f4bf92
Compare
In order for nvcc (CUDA compiler) to not fail the DAPHNE build after switching to C++20, we introduce fmt as a separate dependency and upgrade the spdlog to the tip of the spdlog default branch as of 2024-10-03 for the time being (we'll switch back to a release once that compiles without troubles) because the released spdlog 1.14.1 did not compile with the newer fmt 11.0.2. Closes #842
1f4bf92
to
97300d8
Compare
In order for nvcc (CUDA compiler) to not fail the DAPHNE build after switching to C++20, we introduce fmt as a separate dependency and upgrade the spdlog to the tip of the spdlog default branch as of 2024-10-03 for the time being (we'll switch back to a release once that compiles without troubles) because the released spdlog 1.14.1 did not compile with the newer fmt 11.0.2. Closes #842
97300d8
to
40a6e2b
Compare
The CI build failure seems to be unrelated and the tests run fine on my laptop and the scale-up box. I'll proceed with the merge no not cause any further troubles (see #843). |
In order for nvcc (CUDA compiler) to not fail the DAPHNE build after switching to C++20, we introduce fmt as a separate dependency and upgrade the spdlog to the tip of the spdlog default branch as of 2024-10-03 for the time being (we'll switch back to a release once that compiles without troubles) because the released spdlog 1.14.1 did not compile with the newer fmt 11.0.2. Closes #842
40a6e2b
to
596b9e1
Compare
Updating the docker images right away to accommodate this change. At least for x86-64. ARM folks please get in touch if you run into troubles that you can not resolve on your own 🙈 |
Hi @corepointer , we have a user that runs into this problem with |
I don't have a working ARM development environment at hand to do this quickly (my ARM VM from the OCI always-free tier that I used for this task is occupied with something else atm). Maybe that user of yours can try running the container build scripts themselves (put an "exit" into the container build script after the BASE dev container and before the CUDA stuff). |
In order for nvcc (CUDA compiler) to not fail the DAPHNE build after switching to C++20, we introduce fmt as a separate dependency and upgrade the spdlog to the tip of the spdlog default branch as of 2024-10-03 for the time being (we'll switch back to a release once that compiles without troubles) because the released spdlog 1.14.1 did not compile with the newer fmt 11.0.2.