[DAPHNE-#711] Added data transfer with numpy for arrays of more than 2 dimensions #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ldirry
commented
Aug 11, 2024
•
ldirry
commented
- Previously only numpy arrays with 1 or 2 dimensions were supported.
- Added support for numpy arrays with more than 2 dimensions.
- Implementation is analogous to tensorflow and pytorch with a simple reshape to a 2d numpy array.
- Added tests for ndim numpy arrays transfers.
corepointer
force-pushed
the
711-numpy-multi-dimensions
branch
from
d0ff590 to
180dbce
Compare
…an 2 dimensions - Previously only numpy arrays with 1 or 2 dimensions were supported. - Added support for numpy arrays with more than 2 dimensions. - Implementation is analog to tensorflow and pytorch with a simple reshape to a 2d numpy array. - Added tests for ndim numpy arrays transfers. Closes daphne-eu#807
corepointer
force-pushed
the
711-numpy-multi-dimensions
branch
from
180dbce to
5337d14
Compare
|
LGTM - thx for your contribution @ldirry Tests ran without issues and the code changes seem to be fine. Now after merging it I found a minor glitch: you left the year unchanged while copy&pasting the license header 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.