[DAPHNE-#773] Undetected invalid script args #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed invalid script arguments that try to evaulate an expression - Fixed invalid script arguments that were not literals - Added testcases for single script arguments - Added testcases where Daphne fails in case of an invalid script arguments
|
Thx for your work @ldirry Code and tests LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling daphne, users can provide named script arguments that are available inside the DaphneDSL script.
According to the DaphneDSL language reference, only literals may be passed as script arguments
However, the following calls of daphne with invalid script arguments all passed "successfully" (status code 0) and some didn't even indicate any error.
bin/daphne test/api/cli/scriptargs/printSingleArg.daphne foo="sin(1.23)"bin/daphne test/api/cli/scriptargs/printSingleArg.daphne foo="1.23*4.56"bin/daphne test/api/cli/scriptargs/printSingleArg.daphne foo=10xyz23