Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new role permission to disable conversation deletion #4197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ryanrdetzel
Copy link

Pull Request Template

⚠️ Before Submitting a PR, Please Review:

  • Please ensure that you have thoroughly read and understood the Contributing Docs before submitting your Pull Request.

⚠️ Documentation Updates Notice:

  • Kindly note that documentation updates are managed in this repository: librechat.ai

Summary

Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.

Change Type

Please delete any irrelevant options.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@ryanrdetzel
Copy link
Author

This isn't done (tests and docs) but I wanted to make sure this is valid before doing the additional work.

My reasoning for this is I'd like to allow my kids to use this but I want to limit what features that have access to. This is the first of a few permissions changes (can't edit messages for example) and maybe a new role (LIMITED, RESTRICTED) that includes these by default?

@danny-avila
Copy link
Owner

I understand your use case. I'm hesitant to add something like this myself because not allowing deletions is against GDPR and I would generally not like to encourage it. However, I understand the flexibility this offers.

It would make more sense to make DELETE a new Permission and CONVERSATIONS a new PermissionType.

Also, I think you are missing the check on the "Clear all Chats" in the Account Settings Dialog, as well as preventing deletion of archived convos which may be a way to circumvent the current checks (and perhaps ARCHIVE makes sense as another permission, although it may only apply to conversations atm, but this would be out of scope for the current PR)

@michnovka
Copy link

Hi @danny-avila interesting pov on the GDPR side, but imo having control over your own kids is above any GDPR laws and definitely not where GDPR aims to protect citizens. I would also appreciate having the ability to disable deletion for some accounts.

Also, this should likely go hand-in-hand with anonymous chats, should they ever be implemented. I dont want my kids to be able to use those for the very same reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants