Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ecto to 3.2 + add basic many_to_many support #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mergefailure
Copy link

No description provided.

@mergefailure
Copy link
Author

Any thoughts

@danmarcab
Copy link
Owner

Hi @mergefailure , thanks for this!

For some reason github didn't notify me about this. I will take a look and come back to you soon.

@danmarcab
Copy link
Owner

danmarcab commented Dec 3, 2019

Hi again @mergefailure , I would like to keep this small library compatible with ecto 2 and 3. I am not actually using it right now but I know some places where they are using it with ecto 2.

Ideally I would like to have some way of testing this, for example having 2 example apps, one with ecto 2 and one with ecto 3. It would be awesome if we could run this tests in a CI (maybe github actions?)

Regarding the many to many associations, it a good point, and certainly we could improve a lot on that side. Again I would need some tests written to prove this works. You can see a couple of tests written for the supported associations in the test folder.

So ideally I would like to split this into 3 tasks:

  • Make tests run on CI (github actions? circleci?) done in 9d88ac9
  • Make sure ecto 2 and 3 are supported (with tests)
  • Add basic many to many association support (with tests)

Ping me if you want to have a deeper look to any of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants