fix: #997 use setting env value over default values

danielmiessler · Sep 26, 2024 · dd83d7f · dd83d7f
1 parent 28937bb
commit dd83d7f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/common/configurable.go b/common/configurable.go
@@ -103,8 +103,9 @@ func (o *Setting) IsDefined() bool {
 }
 
 func (o *Setting) Configure() error {
-	if o.Value == "" {
-		o.Value = os.Getenv(o.EnvVariable)
+	envValue := os.Getenv(o.EnvVariable)
+	if envValue != "" {
+		o.Value = envValue
 	}
 	return o.IsValidErr()
 }