chore(deps): update git2 to use libgit2 1.9 #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
libgit2-1.8
branch
from
b90f249 to
9d6101e
Compare
chenrui333
changed the title
6 tasks
th1000s
reviewed
Jan 9, 2025
| @@ -1,6 +1,6 @@ | |||
| # This file is automatically @generated by Cargo. | |||
| # It is not intended for manual editing. | |||
| version = 3 | |||
| version = 4 | |||
There was a problem hiding this comment.
While delta doesn't have a MSRV, this version bump may break older versions. Or do you happen to know when this was introduced, and if delta is already depending on this or a higher version?
There was a problem hiding this comment.
Lockfile v4 has been stable since Rust 1.78. We are making it the default version as of 1.83 nighties unless your MSRV is below 1.78.
There was a problem hiding this comment.
I guess we can just stay with lockfile v4? happy to revert to v3 if you like though.
There was a problem hiding this comment.
1.78 was more than a year ago, thanks for looking that up. The PR it's fine as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump git2 crate to use libgit2 1.9