return error result only from Iterator.next() #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #44 that minimizes the number of methods that return an error result down to (almost, see below) just the
Iterator.next()
implementation inIter
by usingstd::iter::once()
to create an iterator that returns an error result when a failure occurs in theCursor.iter*()
methods.The only exception is Cursor.iter_dup_from(), which still returns an error result because I encountered a compiler panic while trying to convert it to return an iterator that returns an error result. (I'm still looking at this to figure out if it's possible to work around the failure.)
A potential downside of this approach is that it returns an Iterator trait object from the
Cursor.iter*()
methods, which could have runtime performance implications in theory (although I'm unsure that it does in practice).