Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: use -fobjc-arc only with clangs #79

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

barracuda156
Copy link
Contributor

-fobjc-arc is not a valid flag with GCC. Use it only with Clang.

I agree that my contributions are licensed under the MIT License.
You can find a copy of this license at https://opensource.org/licenses/MIT

@dacap
Copy link
Owner

dacap commented Dec 6, 2024

Hi @barracuda156, thanks for this patch, would you mind to change CMAKE_C_COMPILER_ID to CMAKE_CXX_COMPILER_ID? as we use the C++ compiler for this project.

@barracuda156
Copy link
Contributor Author

barracuda156 commented Dec 6, 2024

@dacap Thank you, this indeed should be changed. I will fix that.

UPD. Done

@dacap
Copy link
Owner

dacap commented Dec 9, 2024

Thanks @barracuda156, I'll merge it!

@dacap dacap merged commit 4bd90a5 into dacap:main Dec 9, 2024
10 checks passed
@barracuda156 barracuda156 deleted the apple branch December 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants