Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /admin/communities endpoints for admin App Community management. #73

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

psarando
Copy link
Member

This PR will add /admin/communities endpoints for admin App Community management for #71.

These admin endpoints just reuse the regular functions used by the /communities endpoints, except they act as the DE grouper user to ensure they always have admin permissions for each action.

The 1 exception to this is POST /admin/communities, which will still add the new community as the requesting user, automatically adding them as an admin to that community.

Copy link
Member

@ash3rz ash3rz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though Sarah should probably still review because 🐟 is scary) :shipit:

Copy link
Member

@slr71 slr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@psarando
Copy link
Member Author

Thanks for the reviews! 👍

@psarando psarando merged commit aa26216 into cyverse-de:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants