Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand source and destination paths #89

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Aug 16, 2023

Description

This PR adds capabilities to CytoTable for source and destination path expansion (using ~ and environment variable replacements) and resolution (using . and .. to navigate an absolute path). This work comes up as the result of collaborations with @shntnu .

Closes #88

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs changed the title Expand paths Expand source and destination paths Aug 16, 2023
tests/test_convert.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I imagine being able to use variables and relative references will be appreciated by your users. I left a few comments, but I didn't see anything of enough concern not to approve it.

cytotable/utils.py Outdated Show resolved Hide resolved
cytotable/utils.py Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Aug 18, 2023

Thank you @gwaybio and @falquaddoomi for your reviews! Merging after addressing your comments.

@d33bs d33bs merged commit c0d2077 into cytomining:main Aug 18, 2023
7 checks passed
@d33bs d33bs deleted the expand-paths branch August 18, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source and destination path resolution for common substitution symbols (ex. ~)
3 participants