Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tablenumber capabilities to distinguish repeated image numbers from multiple datasets #188

Merged
merged 14 commits into from
Oct 25, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Apr 12, 2024

Description

This PR addresses #30 by adding a tablenumber by user specification or automatically when there are multiple datasets being parsed by CytoTable. I encountered #187 during implementation, which I feel is a complex issue we shouldn't solve in this PR.

Closes #30

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review October 24, 2024 15:34
cytotable/convert.py Outdated Show resolved Hide resolved
cytotable/convert.py Outdated Show resolved Hide resolved
cytotable/convert.py Show resolved Hide resolved
cytotable/convert.py Show resolved Hide resolved
cytotable/convert.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Oct 25, 2024

Thanks for this review @gwaybio ! I'm going to merge this in after responding to your comments.

@d33bs d33bs merged commit ccca87f into cytomining:main Oct 25, 2024
12 checks passed
@d33bs d33bs deleted the add-tablenumbers branch October 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How does CytoTable handle duplicate ImageNumbers?
2 participants