Skip to content

Commit

Permalink
Removed debug output (exasol#96)
Browse files Browse the repository at this point in the history
Co-authored-by: Thomas Ritter <[email protected]>
Co-authored-by: Christoph Pirkl <[email protected]>
  • Loading branch information
3 people authored Oct 11, 2023
1 parent cb04bec commit 334e189
Show file tree
Hide file tree
Showing 13 changed files with 40 additions and 31 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/broken_links_checker.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ jobs:
strategy:
matrix:
go: ["1.20", "1.21"]
db: ["7.1.22", "8.22.0"]
db: ["7.1.23", "8.22.0"]
env:
DEFAULT_GO: "1.21"
DEFAULT_DB: "8.22.0"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-go-${{ matrix.go }}-db-${{ matrix.db }}
cancel-in-progress: true
name: Build with go version ${{ matrix.go }} and db ${{ matrix.db }}
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Set up Go
uses: actions/setup-go@v3
Expand All @@ -41,6 +41,9 @@ jobs:
${{ runner.os }}-go-${{ matrix.go }}
${{ runner.os }}-go-
- name: Enable testcontainer reuse
run: echo 'testcontainers.reuse.enable=true' > "$HOME/.testcontainers.properties"

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
Expand All @@ -63,7 +66,7 @@ jobs:
run: go test -v -count 1 -coverprofile=coverage.out ./...

- name: SonarCloud Scan
if: matrix.go == env.DEFAULT_GO && matrix.db == env.DEFAULT_DB && github.repository_owner == 'exasol'
if: matrix.go == env.DEFAULT_GO && matrix.db == env.DEFAULT_DB && github.repository_owner == 'exasol' && env.SONAR_TOKEN != null
uses: SonarSource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/project-keeper-verify.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/project-keeper.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .project-keeper.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
sources:
- type: golang
path: go.mod
version: 1.0.2
version: 1.0.3
2 changes: 1 addition & 1 deletion dependencies.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions doc/changes/changelog.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions doc/changes/changes_1.0.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Exasol Driver go 1.0.3, released 2023-10-11

Code name: Reduce log verbosity

## Summary

This release reduces log verbosity.

## Features

* #97: Reduced log verbosity (contributed by [@sabitor](https://github.com/sabitor))

## Dependency Updates

### Test Dependency Updates

* Updated `golang.org/x/sync:v0.3.0` to `v0.4.0`
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/gorilla/websocket v1.5.0
github.com/stretchr/testify v1.8.4
go.uber.org/goleak v1.2.1
golang.org/x/sync v0.3.0
golang.org/x/sync v0.4.0
gopkg.in/yaml.v3 v3.0.1
)

Expand All @@ -18,5 +18,5 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/rogpeppe/go-internal v1.11.0 // indirect
github.com/stretchr/objx v0.5.1 // indirect
golang.org/x/net v0.14.0 // indirect
golang.org/x/net v0.17.0 // indirect
)
10 changes: 5 additions & 5 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/version/version.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package version

const DriverVersion = "v1.0.2"
const DriverVersion = "v1.0.3"
12 changes: 1 addition & 11 deletions itest/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,24 +60,14 @@ func (suite *IntegrationTestSuite) TestConnect() {
suite.Equal("2", columns[0])
}

func (suite *IntegrationTestSuite) isExasol7_0_x() bool {
return strings.HasPrefix(suite.exasol.DbVersion, "7.0.")
}

func (suite *IntegrationTestSuite) TestConnection() {
actualFingerprint := suite.getActualCertificateFingerprint()
const wrongFingerprint = "wrongFingerprint"
const noError = ""

errorMsgWrongFingerprint := fmt.Sprintf("E-EGOD-10: the server's certificate fingerprint '%s' does not match the expected fingerprint '%s'", actualFingerprint, wrongFingerprint)
const errorMsgAuthFailed = "E-EGOD-11: execution failed with SQL error code '08004' and message 'Connection exception - authentication failed.'"

var errorMsgTokenAuthFailed string
if suite.isExasol7_0_x() {
errorMsgTokenAuthFailed = "E-EGOD-11: execution failed with SQL error code '00000' and message 'Invalid login request command: loginToken'"
} else {
errorMsgTokenAuthFailed = "E-EGOD-11: execution failed with SQL error code '08004' and message 'Connection exception - authentication failed'"
}
const errorMsgTokenAuthFailed = "E-EGOD-11: execution failed with SQL error code '08004' and message 'Connection exception - authentication failed'"

var errorMsgCertWrongHost string
if suite.host == "localhost" {
Expand Down
2 changes: 0 additions & 2 deletions pkg/connection/connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"encoding/base64"
"encoding/hex"
"fmt"
"log"
"math/big"
"os/user"
"runtime"
Expand Down Expand Up @@ -279,7 +278,6 @@ func (c *Connection) SimpleExec(ctx context.Context, query string) (*types.SqlQu
}

func (c *Connection) close(ctx context.Context) error {
log.Printf("Closing connection")
c.IsClosed = true
err := c.Send(ctx, &types.Command{Command: "disconnect"}, nil)
closeError := c.websocket.Close()
Expand Down

0 comments on commit 334e189

Please sign in to comment.