ENG-14702: Update documentation for repo level policies #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy test case to use one of the supported rego templates (object-protection).
yoursnerdly
reviewed
Dec 30, 2024
yoursnerdly
reviewed
Dec 30, 2024
…em under a deprecation note.
gengdahlCyral
changed the title
yoursnerdly
reviewed
Dec 30, 2024
| @@ -71,15 +71,38 @@ All templates use parameters defined as JSON, below is a list of all the corresp | |||
|
|
|||
| -> You can also use the Cyral API `GET` `/v1/regopolicies/templates` to retrieve all existing templates and their corresponding parameters schema. | |||
|
|
|||
| ### Data Firewall (data-firewall) | |||
| ### Object Protection (object-protection) | |||
There was a problem hiding this comment.
Since we're updating this, maybe add information about the two new templates (ungoverned-statements and fail-closed) should be added as well.
yoursnerdly
reviewed
Dec 30, 2024
gengdahlCyral
commented
Dec 30, 2024
yoursnerdly
changed the title
|
yoursnerdly
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
LGTM - @gengdahlCyral please let me know if you have any further suggestions related to documentation update.
gengdahlCyral
commented
Jan 2, 2025
There was a problem hiding this comment.
Looks good to me, do you want to do merge and tag @yoursnerdly ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added deprecation note to deprecated rego templates and updated rego policy test case to use one of the supported rego templates (object-protection).
Type of change
Checklists
Development
Code review
Testing
UT