Simplify core package #474

wcmjunior · 2023-11-07T07:13:33Z

Description of the change

Rename ResourceData and ResponseData as SchemaReader and SchemaWriter, respectively.
Rename NewResourceData and NewResponseData as SchemaReaderFactory and SchemaWriterFactory, respectively.
Provide a default implementation for CreateContext, ReadContext, UpdateContext and DeleteContext operations in core/default_context_handlers.go. It will greatly simplify how to write resources and datasources to standard API that is comprised of POST, GET, UPDATE and DELETE for the respective CRUD operations and that also just return a simply ID after the create (POST) call.
Use the appropriate Terraform logging framework by replacing calls to log.Printf("[DEBUG] ...") by calls to tflog.Debug.
Migrate the following resources and data sources to the new proposed framework:
- cyral_integration_hc_vault
- cyral_saml_certificate
- cyral_integration_slack_alerts
- cyral_integration_microsoft_teams
- cyral_repository_user_account
Bump golang to 1.21.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
Jira issue referenced in commit message and/or PR title

Testing

Testing report:

go clean -i github.com/cyralinc/terraform-provider-cyral/...
rm -f terraform-provider-cyral_v4.7.2
rm -rf ./out
rm -rf ~/.terraform.d/plugins/local/terraform/cyral/4.7.2
gofmt -w .
mkdir -p out/
# Build for both MacOS and Linux
GOOS=darwin GOARCH=amd64 go build -o out/darwin_amd64/terraform-provider-cyral_v4.7.2 .
GOOS=darwin GOARCH=arm64 go build -o out/darwin_arm64/terraform-provider-cyral_v4.7.2 .
GOOS=linux GOARCH=amd64 go build -o out/linux_amd64/terraform-provider-cyral_v4.7.2 .
mkdir -p ~/.terraform.d/plugins/local/terraform/cyral/4.7.2/darwin_amd64
mkdir -p ~/.terraform.d/plugins/local/terraform/cyral/4.7.2/darwin_arm64
mkdir -p ~/.terraform.d/plugins/local/terraform/cyral/4.7.2/linux_amd64
cp out/darwin_arm64/terraform-provider-cyral_v4.7.2 ~/.terraform.d/plugins/local/terraform/cyral/4.7.2/darwin_arm64
cp out/linux_amd64/terraform-provider-cyral_v4.7.2 ~/.terraform.d/plugins/local/terraform/cyral/4.7.2/linux_amd64
cp out/darwin_amd64/terraform-provider-cyral_v4.7.2 ~/.terraform.d/plugins/local/terraform/cyral/4.7.2/darwin_amd64
go test github.com/cyralinc/terraform-provider-cyral/... -v -race -timeout 20m
?       github.com/cyralinc/terraform-provider-cyral    [no test files]
?       github.com/cyralinc/terraform-provider-cyral/cyral/core [no test files]
?       github.com/cyralinc/terraform-provider-cyral/cyral/core/types/operationtype     [no test files]
?       github.com/cyralinc/terraform-provider-cyral/cyral/core/types/resourcetype      [no test files]
=== RUN   TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue
--- PASS: TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue (0.00s)
=== RUN   TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse
--- PASS: TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse (0.00s)
=== RUN   TestNewClient_WhenClientIDIsEmpty_ThenThrowError
--- PASS: TestNewClient_WhenClientIDIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenClientSecretIsEmpty_ThenThrowError
--- PASS: TestNewClient_WhenClientSecretIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError
--- PASS: TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError (0.00s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/client       (cached)
?       github.com/cyralinc/terraform-provider-cyral/cyral/internal/datalabel/classificationrule        [no test files]
?       github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/confextension   [no test files]
=== RUN   TestAccDatalabelDataSource
=== PAUSE TestAccDatalabelDataSource
=== RUN   TestAccDatalabelResource
--- PASS: TestAccDatalabelResource (6.06s)
=== CONT  TestAccDatalabelDataSource
--- PASS: TestAccDatalabelDataSource (30.24s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/datalabel   37.624s
=== RUN   TestAccSidecarCftTemplateDataSource
=== PAUSE TestAccSidecarCftTemplateDataSource
=== RUN   TestAccSidecarInstanceIDsDataSource
=== PAUSE TestAccSidecarInstanceIDsDataSource
=== RUN   TestIntegrationsData_GetValue_Default
--- PASS: TestIntegrationsData_GetValue_Default (0.00s)
=== RUN   TestIntegrationsData_GetValue_Splunk
--- PASS: TestIntegrationsData_GetValue_Splunk (0.00s)
=== RUN   TestAccDatadogIntegrationResource
=== PAUSE TestAccDatadogIntegrationResource
=== RUN   TestAccELKIntegrationResource
=== PAUSE TestAccELKIntegrationResource
=== RUN   TestAccIdPIntegrationResource
=== PAUSE TestAccIdPIntegrationResource
=== RUN   TestAccLogstashIntegrationResource
=== PAUSE TestAccLogstashIntegrationResource
=== RUN   TestAccLookerIntegrationResource
=== PAUSE TestAccLookerIntegrationResource
=== RUN   TestAccSplunkIntegrationResource
=== PAUSE TestAccSplunkIntegrationResource
=== RUN   TestAccSumoLogicIntegrationResource
=== PAUSE TestAccSumoLogicIntegrationResource
=== CONT  TestAccDatadogIntegrationResource
=== CONT  TestAccLookerIntegrationResource
=== CONT  TestAccSumoLogicIntegrationResource
=== CONT  TestAccSplunkIntegrationResource
=== CONT  TestAccLogstashIntegrationResource
=== CONT  TestAccIdPIntegrationResource
=== CONT  TestAccELKIntegrationResource
=== CONT  TestAccSidecarInstanceIDsDataSource
=== CONT  TestAccSidecarCftTemplateDataSource
--- PASS: TestAccSumoLogicIntegrationResource (14.19s)
--- PASS: TestAccLookerIntegrationResource (14.58s)
--- PASS: TestAccDatadogIntegrationResource (15.14s)
--- PASS: TestAccELKIntegrationResource (15.27s)
--- PASS: TestAccSplunkIntegrationResource (17.46s)
--- PASS: TestAccLogstashIntegrationResource (25.46s)
--- PASS: TestAccSidecarCftTemplateDataSource (26.74s)
--- PASS: TestAccSidecarInstanceIDsDataSource (34.74s)
--- PASS: TestAccIdPIntegrationResource (90.42s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/deprecated  92.773s
=== RUN   TestIntegrationAWSIAMAuthN
=== PAUSE TestIntegrationAWSIAMAuthN
=== CONT  TestIntegrationAWSIAMAuthN
--- PASS: TestIntegrationAWSIAMAuthN (28.31s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/awsiam  30.955s
=== RUN   TestAccDuoMFAIntegrationResource
=== PAUSE TestAccDuoMFAIntegrationResource
=== CONT  TestAccDuoMFAIntegrationResource
--- PASS: TestAccDuoMFAIntegrationResource (10.87s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/confextension/mfaduo    12.453s
=== RUN   TestAccPagerDutyIntegrationResource
=== PAUSE TestAccPagerDutyIntegrationResource
=== CONT  TestAccPagerDutyIntegrationResource
--- PASS: TestAccPagerDutyIntegrationResource (13.74s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/confextension/pagerduty 15.821s
=== RUN   TestAccHCVaultIntegrationResource
=== PAUSE TestAccHCVaultIntegrationResource
=== CONT  TestAccHCVaultIntegrationResource
--- PASS: TestAccHCVaultIntegrationResource (8.02s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/hcvault 9.847s
=== RUN   TestAccIntegrationIdPSAMLDataSource
=== PAUSE TestAccIntegrationIdPSAMLDataSource
=== RUN   TestAccIntegrationIdPSAMLDraftResource
=== PAUSE TestAccIntegrationIdPSAMLDraftResource
=== RUN   TestAccIntegrationIdPSAMLResource
=== PAUSE TestAccIntegrationIdPSAMLResource
=== CONT  TestAccIntegrationIdPSAMLDataSource
=== CONT  TestAccIntegrationIdPSAMLDraftResource
=== CONT  TestAccIntegrationIdPSAMLResource
--- PASS: TestAccIntegrationIdPSAMLDraftResource (20.13s)
--- PASS: TestAccIntegrationIdPSAMLDataSource (58.32s)
--- PASS: TestAccIntegrationIdPSAMLResource (72.52s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/idpsaml 75.485s
=== RUN   TestAccLoggingIntegrationDataSource
=== PAUSE TestAccLoggingIntegrationDataSource
=== RUN   TestAccLogsIntegrationResourceCloudWatch
=== PAUSE TestAccLogsIntegrationResourceCloudWatch
=== RUN   TestAccLogsIntegrationResourceDataDog
=== PAUSE TestAccLogsIntegrationResourceDataDog
=== RUN   TestAccLogsIntegrationResourceElk
=== PAUSE TestAccLogsIntegrationResourceElk
=== RUN   TestAccLogsIntegrationResourceElkEmptyEsCredentials
=== PAUSE TestAccLogsIntegrationResourceElkEmptyEsCredentials
=== RUN   TestAccLogsIntegrationResourceSplunk
=== PAUSE TestAccLogsIntegrationResourceSplunk
=== RUN   TestAccLogsIntegrationResourceSumologic
=== PAUSE TestAccLogsIntegrationResourceSumologic
=== RUN   TestAccLogsIntegrationResourceFluentbit
=== PAUSE TestAccLogsIntegrationResourceFluentbit
=== CONT  TestAccLoggingIntegrationDataSource
=== CONT  TestAccLogsIntegrationResourceElk
=== CONT  TestAccLogsIntegrationResourceDataDog
=== CONT  TestAccLogsIntegrationResourceFluentbit
=== CONT  TestAccLogsIntegrationResourceSumologic
=== CONT  TestAccLogsIntegrationResourceSplunk
=== CONT  TestAccLogsIntegrationResourceElkEmptyEsCredentials
=== CONT  TestAccLogsIntegrationResourceCloudWatch
--- PASS: TestAccLogsIntegrationResourceDataDog (13.28s)
--- PASS: TestAccLogsIntegrationResourceFluentbit (14.81s)
--- PASS: TestAccLogsIntegrationResourceElkEmptyEsCredentials (16.28s)
--- PASS: TestAccLogsIntegrationResourceCloudWatch (17.23s)
--- PASS: TestAccLogsIntegrationResourceSumologic (18.17s)
--- PASS: TestAccLogsIntegrationResourceSplunk (18.42s)
--- PASS: TestAccLogsIntegrationResourceElk (18.77s)
--- PASS: TestAccLoggingIntegrationDataSource (19.37s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/logging 22.569s
=== RUN   TestAccSlackAlertsIntegrationResource
=== PAUSE TestAccSlackAlertsIntegrationResource
=== CONT  TestAccSlackAlertsIntegrationResource
--- PASS: TestAccSlackAlertsIntegrationResource (11.83s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/slack   14.650s
=== RUN   TestAccMsTeamsIntegrationResource
=== PAUSE TestAccMsTeamsIntegrationResource
=== CONT  TestAccMsTeamsIntegrationResource
--- PASS: TestAccMsTeamsIntegrationResource (13.24s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/teams   16.358s
=== RUN   TestAccPermissionDataSource
=== PAUSE TestAccPermissionDataSource
=== CONT  TestAccPermissionDataSource
--- PASS: TestAccPermissionDataSource (10.69s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/permission  12.025s
=== RUN   TestAccPolicyResource
=== PAUSE TestAccPolicyResource
=== CONT  TestAccPolicyResource
--- PASS: TestAccPolicyResource (12.81s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/policy      14.128s
=== RUN   TestAccPolicyRuleResource
=== PAUSE TestAccPolicyRuleResource
=== RUN   TestPolicyRuleResourceUpgradeV0
--- PASS: TestPolicyRuleResourceUpgradeV0 (0.00s)
=== CONT  TestAccPolicyRuleResource
--- PASS: TestAccPolicyRuleResource (22.76s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/policy/rule 24.085s
=== RUN   TestAccRegoPolicyInstanceResource
=== PAUSE TestAccRegoPolicyInstanceResource
=== CONT  TestAccRegoPolicyInstanceResource
--- PASS: TestAccRegoPolicyInstanceResource (11.12s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/regopolicy  12.443s
=== RUN   TestAccRepositoryDataSource
=== PAUSE TestAccRepositoryDataSource
=== RUN   TestAccRepositoryResource
=== PAUSE TestAccRepositoryResource
=== CONT  TestAccRepositoryDataSource
=== CONT  TestAccRepositoryResource
--- PASS: TestAccRepositoryDataSource (20.72s)
--- PASS: TestAccRepositoryResource (27.47s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository  28.823s
=== RUN   TestAccRepositoryAccessGatewayResource
=== PAUSE TestAccRepositoryAccessGatewayResource
=== CONT  TestAccRepositoryAccessGatewayResource
--- PASS: TestAccRepositoryAccessGatewayResource (28.67s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/accessgateway    29.993s
=== RUN   TestAccRepositoryAccessRulesResource
=== PAUSE TestAccRepositoryAccessRulesResource
=== CONT  TestAccRepositoryAccessRulesResource
--- PASS: TestAccRepositoryAccessRulesResource (15.86s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/accessrules      17.312s
=== RUN   TestAccRepositoryBindingResource
=== PAUSE TestAccRepositoryBindingResource
=== CONT  TestAccRepositoryBindingResource
--- PASS: TestAccRepositoryBindingResource (17.81s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/binding  19.147s
=== RUN   TestAccRepositoryConfAnalysisResource
=== PAUSE TestAccRepositoryConfAnalysisResource
=== RUN   TestRepositoryConfAnalysisResourceUpgradeV0
--- PASS: TestRepositoryConfAnalysisResourceUpgradeV0 (0.00s)
=== CONT  TestAccRepositoryConfAnalysisResource
--- PASS: TestAccRepositoryConfAnalysisResource (11.28s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/confanalysis     12.600s
=== RUN   TestAccRepositoryConfAuthResource
=== PAUSE TestAccRepositoryConfAuthResource
=== RUN   TestRepositoryConfAuthResourceUpgradeV0
--- PASS: TestRepositoryConfAuthResourceUpgradeV0 (0.00s)
=== CONT  TestAccRepositoryConfAuthResource
--- PASS: TestAccRepositoryConfAuthResource (17.48s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/confauth 18.815s
=== RUN   TestAccRepositoryDatamapResource
=== PAUSE TestAccRepositoryDatamapResource
=== CONT  TestAccRepositoryDatamapResource
--- PASS: TestAccRepositoryDatamapResource (27.41s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/datamap  28.747s
=== RUN   TestAccRepositoryNetworkAccessPolicyResource
=== PAUSE TestAccRepositoryNetworkAccessPolicyResource
=== CONT  TestAccRepositoryNetworkAccessPolicyResource
--- PASS: TestAccRepositoryNetworkAccessPolicyResource (27.36s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/network  28.687s
=== RUN   TestAccRepositoryUserAccountResource
=== PAUSE TestAccRepositoryUserAccountResource
=== CONT  TestAccRepositoryUserAccountResource
--- PASS: TestAccRepositoryUserAccountResource (48.66s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/useraccount      49.997s
=== RUN   TestAccRoleDataSource
=== PAUSE TestAccRoleDataSource
=== RUN   TestAccRoleSSOGroupsResource
=== PAUSE TestAccRoleSSOGroupsResource
=== RUN   TestRoleSSOGroupsResourceUpgradeV0
--- PASS: TestRoleSSOGroupsResourceUpgradeV0 (0.00s)
=== RUN   TestAccRoleResource
=== PAUSE TestAccRoleResource
=== CONT  TestAccRoleDataSource
=== CONT  TestAccRoleSSOGroupsResource
=== CONT  TestAccRoleResource
--- PASS: TestAccRoleDataSource (39.41s)
--- PASS: TestAccRoleSSOGroupsResource (40.66s)
--- PASS: TestAccRoleResource (47.17s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/role        48.508s
=== RUN   TestAccSAMLCertificateDataSource
=== PAUSE TestAccSAMLCertificateDataSource
=== CONT  TestAccSAMLCertificateDataSource
--- PASS: TestAccSAMLCertificateDataSource (5.89s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/samlcertificate     7.197s
=== RUN   TestAccSAMLConfigurationDataSource
=== PAUSE TestAccSAMLConfigurationDataSource
=== CONT  TestAccSAMLConfigurationDataSource
--- PASS: TestAccSAMLConfigurationDataSource (19.96s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/samlconfiguration   21.285s
=== RUN   TestAccServiceAccountResource
=== PAUSE TestAccServiceAccountResource
=== CONT  TestAccServiceAccountResource
--- PASS: TestAccServiceAccountResource (37.54s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/serviceaccount      38.902s
=== RUN   TestAccSidecarBoundPortsDataSource
=== PAUSE TestAccSidecarBoundPortsDataSource
=== RUN   TestAccSidecarIDDataSource
=== PAUSE TestAccSidecarIDDataSource
=== RUN   TestAccSidecarResource
=== PAUSE TestAccSidecarResource
=== CONT  TestAccSidecarBoundPortsDataSource
=== CONT  TestAccSidecarResource
=== CONT  TestAccSidecarIDDataSource
--- PASS: TestAccSidecarIDDataSource (22.10s)
--- PASS: TestAccSidecarBoundPortsDataSource (24.30s)
--- PASS: TestAccSidecarResource (34.05s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar     35.390s
=== RUN   TestAccSidecarCredentialsResource
=== PAUSE TestAccSidecarCredentialsResource
=== CONT  TestAccSidecarCredentialsResource
--- PASS: TestAccSidecarCredentialsResource (19.31s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/credentials 20.658s
=== RUN   TestAccSidecarHealthDataSource
=== PAUSE TestAccSidecarHealthDataSource
=== CONT  TestAccSidecarHealthDataSource
--- PASS: TestAccSidecarHealthDataSource (13.95s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/health      15.265s
=== RUN   TestAccSidecarInstanceStatsDataSource
=== PAUSE TestAccSidecarInstanceStatsDataSource
=== RUN   TestAccSidecarInstanceDataSource
=== PAUSE TestAccSidecarInstanceDataSource
=== CONT  TestAccSidecarInstanceDataSource
=== CONT  TestAccSidecarInstanceStatsDataSource
--- PASS: TestAccSidecarInstanceStatsDataSource (11.90s)
--- PASS: TestAccSidecarInstanceDataSource (12.26s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/instance    13.581s
=== RUN   TestAccSidecarListenerDataSource
=== PAUSE TestAccSidecarListenerDataSource
=== RUN   TestSidecarListenerResource
=== PAUSE TestSidecarListenerResource
=== CONT  TestSidecarListenerResource
=== CONT  TestAccSidecarListenerDataSource
--- PASS: TestAccSidecarListenerDataSource (19.89s)
--- PASS: TestSidecarListenerResource (33.19s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/listener    34.514s
testing: warning: no tests to run
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/sweep       (cached) [no tests to run]
=== RUN   TestAccSystemInfoDataSource
=== PAUSE TestAccSystemInfoDataSource
=== CONT  TestAccSystemInfoDataSource
--- PASS: TestAccSystemInfoDataSource (3.87s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/systeminfo  5.201s
=== RUN   TestAccAccessTokenSettingsResource
=== PAUSE TestAccAccessTokenSettingsResource
=== CONT  TestAccAccessTokenSettingsResource
--- PASS: TestAccAccessTokenSettingsResource (13.70s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/internal/tokensettings       15.011s
=== RUN   TestAccProvider
--- PASS: TestAccProvider (0.00s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/provider     1.271s
=== RUN   TestElementsMatch
--- PASS: TestElementsMatch (0.00s)
PASS
ok      github.com/cyralinc/terraform-provider-cyral/cyral/utils        (cached)

wcmjunior · 2023-11-21T08:42:38Z

@VictorGFM , I still need to fix the build issue, which is not related to the code but to the linter we use. You can start reviewing and providing feedback as you please.

VictorGFM

Great refactoring, thanks for working on this. Please consider my comments below before merging.

cyral/core/README.md

cyral/core/default_context_handler.go

cyral/internal/datalabel/model.go

cyral/internal/repository/useraccount/schema_loader.go

sonarqubecloud · 2023-12-06T09:29:36Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

No Coverage information
7.2% Duplication

wcmjunior added 2 commits November 6, 2023 23:16

Rename ResourceData and ResponseData

f2755a9

Add default response handling for id-based responses

4b5743a

wcmjunior force-pushed the feat/simplify-core branch from 0e900ad to 4b5743a Compare November 7, 2023 07:16

wcmjunior added 6 commits November 18, 2023 01:37

Stable version - few resources refactored

411b9fb

Re-establish tests to normal

86d6a8b

Sync up docs with latest changes

12a813e

Migrate hcvault to new framework

a73d003

Simplify way further :)

bc17c34

Migrate slack, teams and samlcertificate to new framework

14fc58e

wcmjunior marked this pull request as ready for review November 21, 2023 08:41

wcmjunior requested a review from VictorGFM November 21, 2023 08:42

Bump go to 1.21

220ea6a

wcmjunior force-pushed the feat/simplify-core branch from bcd600c to 220ea6a Compare December 2, 2023 06:42

Merge branch 'main' into feat/simplify-core

a227521

VictorGFM approved these changes Dec 5, 2023

View reviewed changes

Address review comments

34c2a8d

wcmjunior merged commit 16d284e into main Dec 6, 2023
3 checks passed

wcmjunior deleted the feat/simplify-core branch December 6, 2023 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify core package #474

Simplify core package #474

wcmjunior commented Nov 7, 2023 •

edited

Loading

wcmjunior commented Nov 21, 2023

VictorGFM left a comment

sonarqubecloud bot commented Dec 6, 2023

Simplify core package #474

Simplify core package #474

Conversation

wcmjunior commented Nov 7, 2023 • edited Loading

Description of the change

Type of change

Checklists

Development

Code review

Testing

wcmjunior commented Nov 21, 2023

VictorGFM left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 6, 2023

wcmjunior commented Nov 7, 2023 •

edited

Loading