-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: update browser icons #30790
Open
mschile
wants to merge
8
commits into
develop
Choose a base branch
from
mschile/browser_icon_updates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
misc: update browser icons #30790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
requested changes
Dec 19, 2024
cypress Run #59315
Run Properties:
|
Project |
cypress
|
Branch Review |
mschile/browser_icon_updates
|
Run status |
Failed #59315
|
Run duration | 47m 23s |
Commit |
56a578a5bb: updates
|
Committer | Matthew Schile |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
3
|
Pending |
1315
|
Skipped |
0
|
Passing |
29157
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.73%
|
|
---|---|
Untested elements |
192
|
Tested elements |
166
|
Accessibility
92.53%
|
|
---|---|
Failed rules |
3 critical
8 serious
2 moderate
2 minor
|
Failed elements |
917
|
Tests for review
src/setup/OpenBrowserList.cy.tsx • 1 failed test • launchpad-ct
Test | Artifacts | |
---|---|---|
> renders a long list of found browsers correctly |
Test Replay
Screenshots
|
cypress/e2e/project-setup.cy.ts • 2 failed tests • launchpad-e2e
Test | Artifacts | |
---|---|---|
... > can setup e2e testing for a project selecting JS |
Test Replay
Screenshots
|
|
... > can setup e2e testing for a project selecting TS |
Test Replay
Screenshots
|
commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > automatically parses application/json request bodies |
Test Replay
|
|
... > stops waiting when an fetch request is canceled |
Test Replay
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
... > throws when foo cannot resolve |
Test Replay
|
cacieprins
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
Verify the icons are correct.
How has the user experience changed?
Browser selection:
Open mode header and dropdown:
Debug:
Run mode header:
Automation missing:
PR Tasks
cypress-documentation
?type definitions
?