Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update browser icons #30790

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 19, 2024

  • Closes n/a

Additional details

  • Updated to use the @cypress-design system browser icons

Steps to test

Verify the icons are correct.

How has the user experience changed?

Browser selection:
Screenshot 2024-12-19 at 9 19 02 AM

Open mode header and dropdown:
Screenshot 2024-12-19 at 9 19 38 AM

Debug:
Screenshot 2024-12-19 at 9 20 33 AM

Run mode header:
Screenshot 2024-12-19 at 9 22 39 AM

Automation missing:
Screenshot 2024-12-20 at 8 33 04 AM

PR Tasks

@mschile mschile self-assigned this Dec 19, 2024
Copy link

cypress bot commented Dec 19, 2024

cypress    Run #59315

Run Properties:  status check failed Failed #59315  •  git commit 56a578a5bb: updates
Project cypress
Branch Review mschile/browser_icon_updates
Run status status check failed Failed #59315
Run duration 47m 23s
Commit git commit 56a578a5bb: updates
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 1315
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29157
View all changes introduced in this branch ↗︎
UI Coverage  45.73%
  Untested elements 192  
  Tested elements 166  
Accessibility  92.53%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 917  

Tests for review

Failed  src/setup/OpenBrowserList.cy.tsx • 1 failed test • launchpad-ct

View Output

Test Artifacts
> renders a long list of found browsers correctly Test Replay Screenshots
Failed  cypress/e2e/project-setup.cy.ts • 2 failed tests • launchpad-e2e

View Output

Test Artifacts
... > can setup e2e testing for a project selecting JS Test Replay Screenshots
... > can setup e2e testing for a project selecting TS Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-electron

View Output

Test Artifacts
... > automatically parses application/json request bodies Test Replay
... > stops waiting when an fetch request is canceled Test Replay
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants