fix: hang when Network.enable is not implemented for a target #30727
+61
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/target_waiting_for_debug_hang
|
| Run status |
|
| Run duration | 23m 52s |
| Commit |
|
| Committer | Matt Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29400
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
907
|
mschile
commented
Dec 9, 2024
ryanthemanuel
approved these changes
Dec 9, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When attaching to a target, we try to call
Network.enableand thenRuntime.runIfWaitingForDebugger. However, since both of these calls are in the sametry/catch, if theNetwork.enablecall throws an error, we never callRuntime.runIfWaitingForDebuggerwhich causes the target to hang.In order to fix the issue, the two calls are now split into their own
try/catchblocks.Steps to test
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?