chore: Update CI workflows path to be current branch workflows file #30534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
changed the title
ryanthemanuel
approved these changes
Nov 4, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-workflow-file-check
|
| Run status |
|
| Run duration | 25m 14s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29395
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
908
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
There were some tests failing in strange ways when contributor PRs were run on our release/14 branch (see #29680). Some of the tests were running in the new Node version and some in the old Node version.
It turns out that for contributor PRs, they always pull in the workflow.yml from the
developbranch to run. We don't see any utility in doing CI this way, so I'm updating the code to checkout the code and run the.circleci/workflows.ymlfile that is in the working directory.Steps to test
Test of this was conducted in this outside contributor PR: #30520
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?