chore: update @packages/reporter react from 16.8.6 to 17.0.2 and updates @types/react* packages from 16x to 17x #30516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: check the test replay |
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/update_react_17
|
| Run status |
|
| Run duration | 23m 28s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29400
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
906
|
AtofStryker
changed the base branch from
develop
to
chore/update_reporter_mobx
AtofStryker
force-pushed
the
chore/update_react_17
branch
from
5d59016 to
07ea3f0
Compare
AtofStryker
force-pushed
the
chore/update_reporter_mobx
branch
from
72a5e4b to
5cca87a
Compare
…tes @types/react* packages from 16x to 17x [run ci]
…r/reporter needing to locate the same react (this is dumb)
…goofy but existing pattern) [run ci]
… exists in react17 [run ci]
AtofStryker
force-pushed
the
chore/update_react_17
branch
from
dd583e9 to
3667d8d
Compare
AtofStryker
requested review from
jennifer-shehane,
cacieprins and
ryanthemanuel
jennifer-shehane
approved these changes
Nov 6, 2024
ryanthemanuel
approved these changes
Nov 6, 2024
AtofStryker
force-pushed
the
chore/update_react_17
branch
from
3667d8d to
6b480f3
Compare
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updates
reactandreact-domin the Cypress Reporter from16xto17xreact-17-2.mp4
react-17-1.mp4
Steps to test
All tests serve as regression tests
Whatever was going on in #7525 doesn't look to be present anymore, as I can add
debuggerstatements just fine in chrome with this updatereact-17-debug-no-hang.mp4
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?