breaking: remove vue2 support in Cypress 14 #30502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
changed the base branch from
develop
to
breaking/remove_nuxt2_support
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_vue2_support
|
| Run status |
|
| Run duration | 20m 55s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
1327
|
Skipped
|
0
|
Passing
|
29360
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.67%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
168
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
894
|
AtofStryker
force-pushed
the
breaking/remove_vue2_support
branch
3 times, most recently
from
2b19bdc to
0a80f91
Compare
AtofStryker
force-pushed
the
breaking/remove_nuxt2_support
branch
from
6f7a3b0 to
f1fcebd
Compare
Base automatically changed from
breaking/remove_nuxt2_support
to
release/14.0.0
November 3, 2024 21:07
AtofStryker
force-pushed
the
breaking/remove_vue2_support
branch
from
0a80f91 to
5c7f7a4
Compare
AtofStryker
added
type: breaking change
Comment on lines
+19
to
+20
| // Alternatively you can use CommonJS syntax: | ||
| // require('./commands') |
There was a problem hiding this comment.
the whole support file or just this line? this line just gets generated in scaffolding cypress is the only reason I ask because we don't use this support file for anything
There was a problem hiding this comment.
Oh ok. Up to you then. I just noticed it was commented out 🤷🏻
ryanthemanuel
approved these changes
Nov 4, 2024
AtofStryker
force-pushed
the
breaking/remove_vue2_support
branch
from
5c7f7a4 to
69d061e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Removes the
cypress/vue2package and vue 2 support from Cypress 14Testing checklist
The option no longer shows up in
pick a framework.Users can continue to scaffold Vue 3 with vite, but the dependencies will not be detected since vue2 is installed
The launchpad will warn the user that the dependencies are not detected
test harness scaffold will fail to mount component
If having an existing project, running the default
cypress/vue2harness will failThe user can install the @cypress/vue2 package as laid out in cypress-io/cypress-documentation#5977 migration guide
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation? chore: remove vue 2 documentation from Component Testing as it will no longer be supported in Cypress 14 cypress-documentation#5977type definitions?